Repository navigation
[WIP] Allow to show a table in the IPython notebook using dataTables. - #4197
Merged
Merged
Conversation
Contributor
|
Looks neat. Are there any weird interactions with ipython's mapping of keyboard commands/shortcuts? I vaguely remember having some issues with that. |
Contributor
Author
|
Rebased and updated to use #4131 @keflavich It doesn't seem that dataTables binds some keyboard event by default, and I didn't find something about this. |
Member
|
@saimn - can you rebase and move the changelog entry in the 1.2 section? (sorry that this didn't get merged in time for 1.1!) |
This feature existed but was broken (astropy#3937 (comment)). Here a new method `show_in_notebook` is added to render a table. The dataTables js file is loaded with requirejs, and a lightweight css style is added using Bootstrap (already available in the notebook).
Contributor
Author
|
@astrofrog done. |
eteq
added a commit
that referenced
this pull request
Oct 7, 2015
Add method to show tables with dataTables in notebook
Member
|
@saimn - because this is actually a fix in that it reactivated a feature that previously existed, we decided it was ok to treat this as a bug fix and merge it for 1.1 (I updated the changelog in the manual merge). Thanks! |
Contributor
Author
|
Great :-), thanks @eteq ! |
eteq
added a commit
that referenced
this pull request
Oct 12, 2015
Add method to show tables with dataTables in notebook
Member
|
backported to v1.1.x in 9889c77 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature existed but was broken (#3937 (comment)). cc @taldcroft @keflavich
Here a new method
show_in_notebookis added (it could replace the_repr_htmlbut it is probably safer to use a separate method for now).The dataTables js file is loaded with requirejs, and a lightweight css style is added using Bootstrap. About the CSS:
so I need to add classes to the HTML table which I do with a ugly(done)..replace, it would be cleaner with Allow to specify CSS classes for Table.pformat #4131