Repository navigation
Allow package to be manually specified in get_pkg_data_* functions - #4079
Merged
Merged
Conversation
Member
Author
|
Huh. I didn't get any of these test failures locally.... |
Member
Author
|
Oh wait, that would be why--I only ran the tests with |
embray
force-pushed
the
utils/pkg-data-manual-pkg
branch
from
August 17, 2015 21:22
a61c1e5 to
4cbeca1
Compare
Member
Author
|
Rebased on top of #4083, on which this PR is now a dependency. |
embray
force-pushed
the
utils/pkg-data-manual-pkg
branch
from
August 17, 2015 21:48
4cbeca1 to
e84de5e
Compare
Member
|
👍 |
Member
Author
|
Gonna go ahead and merge this in a sec. |
embray
added a commit
to embray/astropy
that referenced
this pull request
Aug 28, 2015
package data can be retrieved from packages other than the one the function was called from. Also converted most of the examples for those functions into working doctests, which revealed some bugs in both the tests and the functions themseves. One such test is skipped due to astropy/astropy-data#4
embray
force-pushed
the
utils/pkg-data-manual-pkg
branch
from
August 28, 2015 17:38
9a6bf62 to
58a8f9d
Compare
embray
added a commit
that referenced
this pull request
Aug 28, 2015
Allow package to be manually specified in get_pkg_data_* functions
dhomeier
pushed a commit
to dhomeier/astropy
that referenced
this pull request
Dec 17, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add optional
packageargument toget_pkg_data_*functions so that package data can be retrieved from packages other than the one the function was called from. I got annoyed in writing some tests that I couldn't do this already.Also converted most of the examples for those functions into working doctests, which revealed some bugs in both the tests and the functions themselves.
One such test is skipped due to
astropy/astropy-data#4