Repository navigation
WIP: Fix iteration inside wcslib - #3893
Conversation
|
Thank you very much! I am currently however holding back wcslib-5.x (it is in experimental only) since I have no real pressure to upload, and I want to wait until it works with astropy. |
|
@mdboom - thanks, I'm currently testing this in astrofrog/wcsaxes#168 |
embray
added
the
Affects-dev
|
Yikes, that's a bummer. At least you tracked it down quickly. |
|
Just to confirm, astrofrog/wcsaxes#168 passes again with these changes. |
|
+1 to merge this soon (now?) |
|
@mdboom - when you said
do you mean that we shouldn't merge this PR yet? |
|
There's a new release of wcslib today -- I will test it and either merge that one, or if that fails, merge this one. |
|
wcslib 5.7 introduces a number of other issues. Merging this for now... |
WIP: Fix iteration inside wcslib
This is a fix for #3891, simply by reverting
sph.cto an earlier version. I think these changes were part of an attempt at optimization and not fixing any bug anyway.We should wait and see what the official fix in wcslib will be (I've reported this to Mark Calabretta), but in the meantime, this provides us with an alternative.
@olebole: This is a critical enough bug that you may want to apply it to the Debian package of wcslib 5.x if there is one already.