Repository navigation
add modes for extract_array to return fixed size - #3727
Conversation
See extensive discussion in astropy#3333
|
@hamogu Thanks for the "rebase"! It's still failing some tests - can you have a look? |
|
Should be fixed now. Was a copy & paste error... |
|
@hamogu It's still failing some tests. can you have another look. |
|
Just a couple of sphinx warnings: |
|
@astrofrog I just saw that. |
There was a problem hiding this comment.
@hamogu -- if I had to guess, the sphinx warning is coming from here (or, really, from the two lines above it), because the indentation changes in this section.
|
Seems that I finally caught all the typos. Thanks for pointing them out to me and thanks for your support through this long discussion. I guess I should have found the remaining typos myself, but I have to admit that I have gotten a little frustrated over this PR, so I did not try to build e.g. local sphinx docs and instead just uploaded so that Travis can do that work for me. Please don't make me rebase this again! |
|
It will get merged once @wkerzendorf is back online. Future NDData PRs should go more smoothly, thanks again for getting this working! |
add modes for `extract_array` to return fixed size
|
Thanks @hamogu! |
There was a problem hiding this comment.
"extract array" -> "extract_array"
astropy#3727 (comment) [skip ci]
See extensive discussion in #3333