Skip to content

Upgrade wcslib to 5.4 - #3669

Closed
mdboom wants to merge 10 commits into
astropy:masterfrom
mdboom:wcs/upgrade-50
Closed

mdboom wants to merge 10 commits into
astropy:masterfrom
mdboom:wcs/upgrade-50

Conversation

@mdboom

@mdboom mdboom commented Apr 7, 2015

Copy link
Copy Markdown
Contributor

No description provided.

@mdboom

mdboom commented Apr 7, 2015

Copy link
Copy Markdown
Contributor Author

Fixes #3559.

@stargaser

Copy link
Copy Markdown
Contributor

Wow, this is terrific news! @mdboom do you need help with testing?

@mdboom

mdboom commented Apr 7, 2015

Copy link
Copy Markdown
Contributor Author

Sure. Check it out and try it out on your data (particularly stuff with TPV). Let me know how it goes. It would be nice to add a TPV test here as well.

@mdboom mdboom changed the title Upgrade wcslib to 5.1 Upgrade wcslib to 5.2 Apr 16, 2015
@stargaser

Copy link
Copy Markdown
Contributor

@mdboom I've been in touch with Mark Calabretta and he explained what he's doing and what he's planning in the near future (header parser). He also sent me a link to the not-yet-public v5.2 for evaluation purposes -- I'd like to try some of his utility programs which are stripped out of the version in Astropy.

Do you expect this pull request will need to wait on a possible v5.3? How much time do I have for testing -- is there a target date for v1.1.0 of Astropy?

@mdboom

mdboom commented Apr 16, 2015

Copy link
Copy Markdown
Contributor Author

This pull request will have to wait until at least a release that Mark hasn't declared as beta, so that it will work with wcslib's in the wild and in Debian packages etc. So that's at least 5.3. But it sounds like we're honing in that -- I didn't find any bugs in 5.2 that are revealed by astropy, so that's promising.

The current target date for astropy 1.1 is July 23, 2015 (and, of course, is only approximate).

@mdboom
mdboom force-pushed the wcs/upgrade-50 branch from c27b968 to 0fe6a61 Compare May 4, 2015 14:12
@mdboom

mdboom commented May 4, 2015

Copy link
Copy Markdown
Contributor Author

Closing -- this is not ready to merge. wcslib now handles SIP, so we need to stop handling SIP ourself or it is essentially double-applied.

@mdboom mdboom closed this May 4, 2015
@mdboom mdboom changed the title Upgrade wcslib to 5.2 Upgrade wcslib to 5.4 May 4, 2015
@embray

embray commented May 5, 2015

Copy link
Copy Markdown
Member

D'oh!

@embray embray removed this from the v1.1.0 milestone May 5, 2015
@olebole

olebole commented May 5, 2015

Copy link
Copy Markdown
Member

@mdboom in the astropy 1.1 release notes, could you mention the maximal wcslib version that can be used (probably 5.3.1, right)? For Debian, I will not upload wcslib >= 5.4 to unstable until it is supported by astropy.
Does astropy-1.0 play nicely with the wcslib >=5, <= 5.3.1?

@mdboom

mdboom commented May 6, 2015

Copy link
Copy Markdown
Contributor Author

@olebole: I have included information about supported versions in #3751 (not yet applied). The supported versions are 4.24 to 5.3.1. A warning is raised if a FITS file with SIP keywords is loaded and astropy is linked against wcslib 5.4. If I can implement proper wcslib 5.4 support before astropy 1.1 I will do that, but in the meantime #3751 represents the easy things we can do for now.

@eteq eteq mentioned this pull request May 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants