Skip to content

Conversation

@astrofrog
Copy link
Member

Replaces #2219

Fixes #2029

@astrofrog
Copy link
Member Author

@anizami - thanks for the contribution, and sorry for not identifying the issues sooner! After some local testing, I was able to find out what was causing the issue.

@astrofrog astrofrog self-assigned this Mar 22, 2015
@astrofrog
Copy link
Member Author

@mdboom - could you review the addition of the configuration item and let me know if this is correct?

@embray
Copy link
Member

embray commented Mar 24, 2015

Marked this as "affects release" due to the new config item if nothing else. I personally have no problem adding a new config option in a patch release, but if you disagree we can change the milestone to 1.1.

@astrofrog
Copy link
Member Author

@embray - fine by me - thought just to check, I thought that 'affects-release' just meant that for bugs it was a problem with a released version not just dev? (didn't think we used that for non-bugs?)

@mdboom
Copy link
Contributor

mdboom commented Mar 24, 2015

Yes -- the new ConfigurationItem definition looks fine.

@embray
Copy link
Member

embray commented Mar 24, 2015

It's used for enhancements too--any user-visible change between releases.

@embray
Copy link
Member

embray commented Mar 24, 2015

You can read it equivalently to "This needs a changelog entry". that's one of the main things I use it to check.

@astrofrog astrofrog force-pushed the avoid-repeated-code-2029 branch from 7a03730 to d92544f Compare March 25, 2015 15:54
@astrofrog
Copy link
Member Author

Damn, I think I must have lost the configuration changes when rebasing...

@astrofrog
Copy link
Member Author

Recovered thanks to Dropbox. Version control redundancy is good.

@embray
Copy link
Member

embray commented Mar 30, 2015

So's git reflog ;)

astrofrog added a commit that referenced this pull request Mar 31, 2015
Avoid duplicate code in ``astropy.vo.samp``
@astrofrog astrofrog merged commit 8caf2c3 into astropy:master Mar 31, 2015
@astrofrog
Copy link
Member Author

@embray - thanks, learned something today!

astrofrog added a commit that referenced this pull request Apr 13, 2015
Avoid duplicate code in ``astropy.vo.samp``
@astrofrog astrofrog deleted the avoid-repeated-code-2029 branch July 5, 2016 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor _call_, _notify_, and _reply_ in astropy.vo.samp to avoid repeated code

3 participants