Repository navigation
Update test_eloc_attributes to use "close" comparisons - #3507
Merged
Merged
Conversation
The != comparison was leading to a false positive, but only on some systems (i.e., astropy#3496, where it was failing because of lower precision)
Member
|
I can confirm that this fixes the issue on i386 👍 |
astrofrog
added a commit
that referenced
this pull request
Feb 16, 2015
Update test_eloc_attributes to use "close" comparisons
astrofrog
added a commit
that referenced
this pull request
Feb 16, 2015
Update test_eloc_attributes to use "close" comparisons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was prompted by #3496, where test_eloc_attributes is failing. This PR should close #3496 by switching to
allclosecomparisons. Also, there was a theory problem: the second set of asserts (forel2) was originally written assuming lat and lon should be different. But actually, only lat should be different because the WGS84 geoid is flattened only along the rotation axis, so longitudes aren't affected.As suggested by @astrofrog, this also adds more explanation of exactly why these tests are the way they are in the form of comments.