Repository navigation
Checking scipy version for coordinates module - #3383
Merged
Merged
Conversation
…query_ball_tree needs (>=0.12.0)
…DTree.query_ball_tree needs (>=0.12.0)
embray
added
Affects-dev
Member
|
Thanks! |
embray
added a commit
that referenced
this pull request
Jan 29, 2015
Checking scipy version for coordinates module
embray
added a commit
that referenced
this pull request
Feb 6, 2015
Checking scipy version for coordinates module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a note about the required version for some of the coordinate functions, and checks for it the affected tests.
scipy.spatial.ckdtree.cKDTree.query_ball_treeis used from scipy in a few places, but it appeared only in 0.12.0. Earlier version (tested with 0.10.0) is OK for all the other part of astropy.Related to some of the test failures reported in #3380.