There's no test I could write that demonstrates the problem with doctests that this fixes, but basically when iterating over locals() it was leaving behind some local variables with the names name and val. The doctest runner could sometimes pick up whatever was defined as val and look in that variable for doctests. If this happened to be TimePlotDate (which could happen at random depending on what order the keys in locals() were iterated over), then the doctest runner would fail to skip that test since it was named "val" instead of "TimePlotDate".

@embray - 👏 on figuring this out. This looks good to me from the Time perspective, and I actually like the metaclass registration here.

Weird that this seemed to cause so many tests to break. I didn't have any problem running them locally.

@embray - I had to think a little, but this does seem quite a bit more elegant than the loop that was there, so 👍! (Out of curiosity, just deleting name and val after the loop should have worked as well, correct?)

Though obviously something is still amiss, since the travis failues suggests Time can never be initialized any more... I'll try to investigate.

I also cannot think of a good test, though now that we are making introducing a new Time format easier, it may be good to give an example in the docs and test that. But that is for another issue/PR.

@mhvk You are correct, that probably should have fixed the original issue, but it was easy enough to take this the rest of the way. No idea why the tests are all bombing out now, since it worked fine locally. It's probably something simple that I'll have figured out shortly.

OK, the keys to FORMATS are now class names (cls.__name__, I think), while they used to be cls.name, i.e., attributes set in the different format classes.

@mhvk - I don't quite follow your comment. The keys to *_FORMATS are still cls.name (formally val.name where val was the class). Or am I misinterpreting?

@taldcroft You are--I just pushed a fixed up commit.

Ah, I had the time order of commit and comment swapped in my head.