Repository navigation
Message about unclosed files in affiliated packages - #3156
Merged
Merged
Conversation
…it uses (namely mod_info, which includes an open filehandle) go out of scope when they're no longer needed. Fixes astropy#3156.
Member
|
Fix attached--thanks. I don't think there's really any straightforward way to add a regression test for this. I have some ideas but it's probably not worth the effort. |
Member
|
@astrofrog Go ahead and try it out before I merge, but this did seem to do the trick for me. |
Member
Author
|
@embray - works for me, thanks! |
astrofrog
added a commit
that referenced
this pull request
Nov 29, 2014
Message about unclosed files in affiliated packages
astrofrog
added a commit
that referenced
this pull request
Dec 31, 2014
Message about unclosed files in affiliated packages Conflicts: CHANGES.rst
QuLogic
added a commit
to QuLogic/vispy
that referenced
this pull request
Jun 2, 2015
This should prevent unnecessary variables from polluting the six namespace. It also fixes a resource warning as described in astropy/astropy#3156.
QuLogic
added a commit
to QuLogic/vispy
that referenced
this pull request
Jun 2, 2015
This should prevent unnecessary variables from polluting the six namespace. It also fixes a resource warning as described in astropy/astropy#3156.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For a number of affiliated packages, I see the following when running
python setup.py testwith Python 3.4:This occurs after the tests have run. @cdeil also reported a similar issue in the past.
To reproduce:
Output:
I'm opening this here because I wonder if it's to do with the way we import the six module?