Repository navigation
Improve io.ascii.read guess when inputting file objects - #3132
Merged
Merged
Conversation
This was referenced Nov 24, 2014
Member
|
Looks like a good fix for the specific situation of reading ASCII tables to me. |
Member
|
This seems sensible to me, and for anyone who cares about very big tables, they shouldn't be using guessing anyway. |
taldcroft
added a commit
that referenced
this pull request
Nov 24, 2014
Improve io.ascii.read guess when inputting file objects
Member
|
This also seems to be closely related to #2001, though it didn't fix that issue. |
taldcroft
added a commit
that referenced
this pull request
Dec 31, 2014
Improve io.ascii.read guess when inputting file objects Conflicts: astropy/io/ascii/tests/test_read.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Python 3 (only) the following fails:
This is closely related to #3013 and issues raised in #3109. This PR puts in a fix in the
ui._guess()which reads the entire file into memory if a file object is supplied. This fixes the Python 3 problem and should be more efficient in Python 2 because the file is not re-read during the guess process.