changed Beta1D and Beta2D to Moffat1D and Moffat2D per issue 3029 #3102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astropy/modeling/core.py
Outdated
Member
There was a problem hiding this comment.
Maybe "Moffat" here instead, and in a couple places below.
Member
|
I've waffled a bit over whether or not this needs anything more than the name change--like whether it should try to maintain backwards compatibility or not. But my inclination is leaning toward "no, this is enough". It will need a changelog entry under "API Changes" for 1.0 though. |
Member
|
@astronomeralex Can you please rebase this PR against master? |
Member
|
@astronomeralex - just a reminder, can you rebase this against master? |
hamogu
added a commit
to hamogu/astropy
that referenced
this pull request
Dec 29, 2014
This commit follows on a rebase, where I rebased the work of astropy#3102 on the current master. Thus, this closes astropy#3102 which in turn fixes astropy#3029. @astronomeralex You did a great job in astropy#3102 and if I had not screwed up the rebase (I deleted the wrong line in a merge conflict) then my name would not turn up here at all. I've based this on your branch and github will recognize you are the author for your commits. As you may have observed, it is very uncommon in astropy for other people to take over and finish a pull request that they did not initiate themselves, but I want to make sure that this makes it into the 1.0 release as it will be much harder to change the name of a model once 1.0 is released.
embray
added a commit
that referenced
this pull request
Dec 30, 2014
Rename beta1d and beta2d - solves issue 3029 (This takes over #3102)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these changes are for issue #3029