Repository navigation
Fix Mac/Python 3 issue with too many open files in io.ascii - #3026
Merged
Merged
Conversation
embray
added
Affects-dev
Member
|
It works for me, thanks @AmrAS1! @astrofrog - do you want to try or should I just merge? |
Member
|
Works for me too! |
astrofrog
added a commit
that referenced
this pull request
Oct 14, 2014
Fix Mac/Python 3 issue with too many open files in io.ascii
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's been a while unfortunately, but I just got hold of a Mac to test out #3018 and realized that the cleanup code wasn't calling
PyBuffer_Release, which fixed the issue for me. @astrofrog @taldcroft - Does this work for you?