Ensure Column-ness is stripped for boolean ufuncs; faster copy #2963
+67
−44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In current master, comparisons of columns, like
t['a'] > 0.correctly return anndarrayrather than aColumninstance (see #1446 and #1685). However, this is not true for ufuncs likenp.isfinite(see example below). This PR fixes that oversight, by checking at the end of__array_wrap__whether the function that was used should return an array or a column.At the same time, it includes a small rewrite of
copythat avoids unnecessarily running throughColumninstantiation.I'll add a changelog entry once we agree where it should go.
Note that both are part of #1839; I'm splitting them out here as I think this is a bug that is easier to review separately (and yes, I'll take the rebase hit...).