Skip to content

Doc build warning from io.table.Column - #280

Merged
eteq merged 2 commits into
astropy:masterfrom
eteq:issue-280
Jun 15, 2012
Merged

eteq merged 2 commits into
astropy:masterfrom
eteq:issue-280

Conversation

@eteq

@eteq eteq commented Jun 15, 2012

Copy link
Copy Markdown
Member

After #268 was merged, there's now a sphinx warning about the Column class. The root of the problem is that autosummary is trying to document all the attributes of Column now, and Column is a subclass of numpy.ndarray... and some of the ndarray attributes don't play nice with our doc standard, apparently.

The larger issue here is how/whether to document attributes from superclasses. I think at least for now we should just supress those attributes, but it's an issue to consider further.

@embray

embray commented Jun 13, 2012

Copy link
Copy Markdown
Member

This would explain the problem I'm having in #279. Good to know it wasn't my fault :)

@mdboom

mdboom commented Jun 14, 2012

Copy link
Copy Markdown
Contributor

I generally lead to not documenting things from superclasses, but having a nice obvious link to the documentation for the superclass. But I know people who are less comfortable with OO generally prefer to see everything they can do with an object.

@eteq

eteq commented Jun 14, 2012

Copy link
Copy Markdown
Member Author

@mdboom - I can see it either way, too. For now, I'll try to get it to strip the superclass attributes, and include a link somewhere to the superclass, as that should be pretty easy to do quickly. We can re-visit the question later if people don't like it.

@embray

embray commented Jun 14, 2012

Copy link
Copy Markdown
Member

I think that in this case the ndarray docstring is so extensive, it makes it very hard to find out what you can do specifically with the Column class. Better to leave all the ndarray stuff out and just leave in a link to the Numpy docs.

@eteq

eteq commented Jun 15, 2012

Copy link
Copy Markdown
Member Author

These commits now implement as discussed here - class doc pages show links to the base class, but base class attributes and methods are not displayed.

Note that this is only true for classes documented using automodsumm or automodapi, not the standard sphinx autosummary.

I will merge this tomorrow before release if there are no objections.

eteq added a commit that referenced this pull request Jun 15, 2012
Fix build warning in io.table.Column by supressing base class attribute documentation
@eteq
eteq merged commit 251d3d1 into astropy:master Jun 15, 2012
keflavich pushed a commit to keflavich/astropy that referenced this pull request Oct 9, 2013
Fix build warning in io.table.Column by supressing base class attribute documentation
@eteq
eteq deleted the issue-280 branch May 3, 2015 17:16
astrofrog pushed a commit to astropy/sphinx-automodapi that referenced this pull request Jan 27, 2018
Fix build warning in io.table.Column by supressing base class attribute documentation
jeffjennings pushed a commit to jeffjennings/astropy that referenced this pull request Jul 2, 2025
Improve the description of pyspeckit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants