Skip to content

Standardize section headings around Python documentation standards - #279

Merged
embray merged 2 commits into
astropy:masterfrom
embray:heading-cleanup
Jun 13, 2012
Merged

embray merged 2 commits into
astropy:masterfrom
embray:heading-cleanup

Conversation

@embray

@embray embray commented Jun 13, 2012

Copy link
Copy Markdown
Member

The Python documentation recommends the following convention for section headings for all its documentation:
http://docs.python.org/devguide/documenting.html#sections

(Ironically, the Python developers' guide itself does not appear to follow its own convention).

I think it would be nice though to follow this convention for Astropy's docs too though. This pull request fixes up all our docs to do so, I think (though I could have missed some spots). I did not update the io.fits docs in this PR because I'm working on reorganizing them in another branch (where they will follow this convention).

I'm also having one problem building the docs: When generating the documentation for the astropy.table.Column class there's a table that gets left out because it's malformatted somehow--the table actually comes from the docstrings for ndarray, which Column inherits from.

…s. Required a slight tweak to automodapi too. This mostly works except for one bug where a table coming from the ndarray documentation (which shows up in the API docs for the table.Column clas) is malformed. Not sure why that is happening now.
@astrofrog

Copy link
Copy Markdown
Member

This looks good - just a note that you may need to update one heading after/if #278 is merged.

@embray

embray commented Jun 13, 2012

Copy link
Copy Markdown
Member Author

Sure--this can wait 'til #278 is merged and then update it accordingly.
I'm still concerned about that one warning I'm getting from the Column class--is anyone else having that problem? Any ideas?

@eteq

eteq commented Jun 13, 2012

Copy link
Copy Markdown
Member

The column warning comes from #268 - I just created #280 to track it and make sure we have it fixed by 0.1.

@eteq

eteq commented Jun 13, 2012

Copy link
Copy Markdown
Member

I'm fine with this change, except for one concern: automodapi currently uses '^' and '_' for it's sub-sections and sub-sub-sections by default. Should this be changed to '-' and '^' now, then?

@embray

embray commented Jun 13, 2012

Copy link
Copy Markdown
Member Author

@eteq Yeah, if you look at the diff I updated automodapi exactly as you suggested :) (Without doing so I got some nasty warnings about inconsistent headings)

@eteq

eteq commented Jun 13, 2012

Copy link
Copy Markdown
Member

@iguananaut - Ah, I see - so you did... but you didn't update the docstring for Automodapi where it says Defaults to "^_", so that threw me off :) At any rate, once you update that docstring accordingly, feel free to merge as far as I'm concerned.

@astrofrog

Copy link
Copy Markdown
Member

@iguananaut - feel free to merge before #278, and I'll update #278 accordingly

@embray

embray commented Jun 13, 2012

Copy link
Copy Markdown
Member Author

Okay

embray added a commit that referenced this pull request Jun 13, 2012
Standardize section headings around Python documentation standards
@embray
embray merged commit a7efe10 into astropy:master Jun 13, 2012
@eteq eteq mentioned this pull request Jun 13, 2012
@embray

embray commented Jun 13, 2012

Copy link
Copy Markdown
Member Author

Oops--is there some way to reopen a pull request? I didn't even realize there were tests for automodapi.
In any case, I'll be sure to fix them.

embray added a commit that referenced this pull request Jun 13, 2012
embray added a commit to embray/astropy that referenced this pull request Jun 14, 2012
@eteq

eteq commented Jun 14, 2012

Copy link
Copy Markdown
Member

@iguananaut - FYI, I don't think it's possible to re-open, as that would require "un-merging". But your solution here if just referencing them from another commit worked fine.

keflavich pushed a commit to keflavich/astropy that referenced this pull request Oct 9, 2013
Standardize section headings around Python documentation standards
keflavich pushed a commit to keflavich/astropy that referenced this pull request Oct 9, 2013
keflavich pushed a commit to keflavich/astropy that referenced this pull request Oct 9, 2013
astrofrog pushed a commit to astropy/sphinx-automodapi that referenced this pull request Jan 27, 2018
Standardize section headings around Python documentation standards
astrofrog added a commit to astrofrog/astropy that referenced this pull request Jun 12, 2019
Need to run bootstrap.py when installing the developer version of setuptools
jeffjennings pushed a commit to jeffjennings/astropy that referenced this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants