Skip to content

cosmology docs section - #272

Merged
eteq merged 10 commits into
astropy:masterfrom
eteq:docs/cosmo-docs
Jun 14, 2012
Merged

eteq merged 10 commits into
astropy:masterfrom
eteq:docs/cosmo-docs

Conversation

@eteq

@eteq eteq commented Jun 9, 2012

Copy link
Copy Markdown
Member

This adds a section for astropy.cosmology to the documentation. Note that the "getting started" and "using" sections are currently unpopulated.

@nhmc, you're probably more qualified to populate these sections. do you think you can do this soon (for the 0.1 release)? If so, you could issue a pull request to my branch with this change, or if you prefer we can merge this and you can make your own branch off master.

@eteq

eteq commented Jun 12, 2012

Copy link
Copy Markdown
Member Author

I've now populated the sections with a mix of text generated by @nhmc (sent to me off github), and some additions I've made. There are also a few tweaks that make the docs build a bit better.

Comment thread docs/cosmology.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for calculating

@astrofrog

Copy link
Copy Markdown
Member

Apart from my comments above, looks fine to me.

@eteq

eteq commented Jun 13, 2012

Copy link
Copy Markdown
Member Author

@astrofrog - I've implemented your suggestions here. I'll merge this in a day or so if there aren't further comments.

Comment thread docs/cosmology.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a last typo: convenience

@eteq

eteq commented Jun 13, 2012

Copy link
Copy Markdown
Member Author

This has been rebased for and updated to reflect the scheme from #279

@astrofrog

Copy link
Copy Markdown
Member

I still see an instance of 'convinience' in the diff (should be convenience) - but once you've fixed that, feel free to merge.

@eteq

eteq commented Jun 14, 2012

Copy link
Copy Markdown
Member Author

@astrofrog For some reason that word is a mental block for me - every time I misspell it and have to go back and fix it.

Anyway, fixed now. I'll merge this now to facilitate some of the pending work, but @nhmc, if you have any changes, feel free to open a new PR or comment further here.

eteq added a commit that referenced this pull request Jun 14, 2012
@eteq
eteq merged commit fad820b into astropy:master Jun 14, 2012
Comment thread docs/cosmology.rst

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

measured

Comment thread docs/cosmology.rst

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the full stop (period) at the end of set_current`

@nhmc

nhmc commented Jun 14, 2012

Copy link
Copy Markdown
Contributor

Thanks for putting this together, it looks good! I just added a few more suggestions and typo corrections. I can start a pull request myself next week, or if you want to apply them that's fine too.

eteq added a commit that referenced this pull request Jun 15, 2012
@eteq

eteq commented Jun 15, 2012

Copy link
Copy Markdown
Member Author

Thanks, @nhmc - These all sounded good and were straightforward, so I applied them directly in master as 6d8c2cd

keflavich pushed a commit to keflavich/astropy that referenced this pull request Oct 9, 2013
keflavich pushed a commit to keflavich/astropy that referenced this pull request Oct 9, 2013
@eteq
eteq deleted the docs/cosmo-docs branch May 3, 2015 17:16
astrofrog pushed a commit to astrofrog/astropy that referenced this pull request Jun 12, 2019
ntessore pushed a commit to glass-dev/cosmology that referenced this pull request Dec 7, 2020
jeffjennings pushed a commit to jeffjennings/astropy that referenced this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants