Skip to content

Update tools and utils to the subpackage template form - #271

Merged
eteq merged 3 commits into
astropy:masterfrom
eteq:docs/tools-utils-to-subpkg-templ
Jun 13, 2012
Merged

eteq merged 3 commits into
astropy:masterfrom
eteq:docs/tools-utils-to-subpkg-templ

Conversation

@eteq

@eteq eteq commented Jun 9, 2012

Copy link
Copy Markdown
Member

This updates the tools and utils package to reflect the standard form. Note that this isn't fully true, because utils is such a grab-bag that it didn't really make sense how to "use" the whole module. Similarly, tools is pretty unpopulated so far, so I left a commented-out using section to later be brought back in.

Comment thread docs/index.rst

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it make sense to keep a utils directory rather than having a bunch of .rst files at the top level? Just a personal preference, I guess.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My idea was that if there's more than one .rst file, the directory definitely makes sense. But the use of :automodapi: here removes the need for distinct api_*.rst files, so right now only one file is needed. If in the future someone wants to make a separate page, then it should be moved into its own directory.

This point should definitely be documented somewhere, though - where do you think it goes... The documentation guidelines, the subpackage template, or a commented area in the .rst files?

@mdboom

mdboom commented Jun 11, 2012

Copy link
Copy Markdown
Contributor

Looks fine, other than the question of directory layout.

@eteq

eteq commented Jun 12, 2012

Copy link
Copy Markdown
Member Author

@iguananaut @astrofrog @taldcroft - as people who've recently worked with updating to this doc standard: what do you think of the discussion above regarding separate directories? Is it ok as I've done here (single files don't get directories, but we move them into directories once someone wants a second file)?

@astrofrog

Copy link
Copy Markdown
Member

@eteq - part of me thinks we should just put the pages in the right place, just in case anyone links to them - i.e. if someone links to docs.astropy.org/cosmology.html, the link will break if we then move the page to docs.astropy.org/cosmology/index.html.

@taldcroft

Copy link
Copy Markdown
Member

I agree with @astrofrog that we should have a structure that avoids future link breakage to the extent possible, certainly at the top levels of our docs. One could even take this to the level of saying that every top-level section in AstroPy should be a directory, which makes every such topic available as <section>/index.html or just <section>/. But I don't think we need to have everything exactly perfect for 0.1. :-)

@embray

embray commented Jun 12, 2012

Copy link
Copy Markdown
Member

+1; if we think it might go into a separate directory later it's preferable to go ahead and lay it out that way.

@mdboom

mdboom commented Jun 12, 2012

Copy link
Copy Markdown
Contributor

+1 on separate directories

@eteq

eteq commented Jun 13, 2012

Copy link
Copy Markdown
Member Author

I hadn't thought about the link-breaking problem - very good point. With that in mind, I agree that it makes more sense to just have them start out in a directory.

I'll go ahead and merge this so we have these docs in place, and then create a new PR to put everything in its own directory.

eteq added a commit that referenced this pull request Jun 13, 2012
Update tools and utils to the subpackage template form
@eteq
eteq merged commit 25f57d3 into astropy:master Jun 13, 2012
keflavich pushed a commit to keflavich/astropy that referenced this pull request Oct 9, 2013
…empl

Update tools and utils to the subpackage template form
@eteq
eteq deleted the docs/tools-utils-to-subpkg-templ branch May 3, 2015 17:17
jeffjennings pushed a commit to jeffjennings/astropy that referenced this pull request Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants