Repository navigation
Fix sky coord init nodata - #2620
Merged
Merged
Conversation
Member
Author
|
This is now rebased and should be ready to go now that #2586 is merged - @taldcroft you might want to just take a quick glance to make sure it looks fine to you. |
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE UNTIL #2586 IS IN
This closes #2613 by simply adding a check to make sure a
SkyCoordhas data after all the initialization steps are done.It also fixes some quirks I noticed in how exceptions are handled for the case where a frame has no data. The basic problem was that the
dataproperty was raising anAttributeErrorthat wouldn't be recognized in__getattr__. This sidesteps it by changing the relevant exception to aValueErrorso that the user will again see a more helpful message that the frame has no data.This is built from #2586 because otherwise there'd be conflicting changes. So once #2586 is in, I'll rebase and this can be merged. But in the meantime, just look at the last two commits to see what this actually does.
cc @taldcroft @cdeil