Skip to content

Conversation

@cdeil
Copy link
Member

@cdeil cdeil commented May 27, 2014

Parallel testing doesn't work on my Mac at the moment because apparently there's two problems with non-deterministic test case collection:
https://gist.github.com/cdeil/9611d070beb593ce0f4c

9bfee8f fixes the first issue, but there's still this one in astropy.table:

INTERNALERROR> -astropy/table/table.py::astropy.table.table.Row
INTERNALERROR> +astropy/table/table.py::astropy.table.table.Table.Row

@taldcroft Can you reproduce? Any idea how to fix this?
(I think #1402 is unrelated?)

@cdeil
Copy link
Member Author

cdeil commented May 28, 2014

I think these travis-ci failures are unrelated to the change in this PR?
https://travis-ci.org/astropy/astropy/jobs/26157311
Any idea why they happened?

@astrofrog I think this issue should be labeled "bug" and be assigned to the 0.4.0 or 0.4.1 milestone?

@embray
Copy link
Member

embray commented May 29, 2014

The test problems are due to #2576 .

@astrofrog
Copy link
Member

@cdeil - is this still needed?

@cdeil
Copy link
Member Author

cdeil commented Jul 22, 2014

@astrofrog - The attached commit does fix a parallel test error ... I don't know why you wouldn't want to merge it. Unless making parallel testing work is no longer a goal, then yes, you can close this issue.

@astrofrog
Copy link
Member

@cdeil - ok cool, just checking - I forgot that we had disabled the parallel tests on Travis, but of course we still need this locally. Now the question is, is this the right fix or should the workaround be in the test? Could one iterate over the dict using sorted keys in the tests rather than forcing this dict to be an OrderedDict?

@cdeil
Copy link
Member Author

cdeil commented Jul 22, 2014

Probably the change could also be made in the tests.
But what's wrong with using an OrderedDict here?
There's no drawback as far as I can see (performance is not an issue here).

@embray embray added this to the v0.4.2 milestone Aug 13, 2014
@embray
Copy link
Member

embray commented Aug 13, 2014

I certainly see no harm in this.

@astrofrog
Copy link
Member

Ok, then let's merge! :)

astrofrog added a commit that referenced this pull request Aug 15, 2014
@astrofrog astrofrog merged commit 9389aae into astropy:master Aug 15, 2014
astrofrog added a commit that referenced this pull request Sep 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release coordinates testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants