-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Parallel testing fixes #2565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parallel testing fixes #2565
Conversation
|
I think these @astrofrog I think this issue should be labeled "bug" and be assigned to the 0.4.0 or 0.4.1 milestone? |
|
The test problems are due to #2576 . |
|
@cdeil - is this still needed? |
|
@astrofrog - The attached commit does fix a parallel test error ... I don't know why you wouldn't want to merge it. Unless making parallel testing work is no longer a goal, then yes, you can close this issue. |
|
@cdeil - ok cool, just checking - I forgot that we had disabled the parallel tests on Travis, but of course we still need this locally. Now the question is, is this the right fix or should the workaround be in the test? Could one iterate over the dict using sorted keys in the tests rather than forcing this dict to be an OrderedDict? |
|
Probably the change could also be made in the tests. |
|
I certainly see no harm in this. |
|
Ok, then let's merge! :) |
Parallel testing doesn't work on my Mac at the moment because apparently there's two problems with non-deterministic test case collection:
https://gist.github.com/cdeil/9611d070beb593ce0f4c
9bfee8f fixes the first issue, but there's still this one in
astropy.table:@taldcroft Can you reproduce? Any idea how to fix this?
(I think #1402 is unrelated?)