-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Update coordinates docs for APE5 #2513
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Oh, and in case it's not apparent, I specifically mentioned places that require more work with |
|
@eteq - shall we do PRs against your branch? |
|
I'm AFK today so won't have any inputs until later. |
|
@astrofrog - either way is fine with me - the tests are passing as-is, so this can be merged now if you or @taldcroft don't want to read over this now and would rather do separate PRs. Or if you'd rather take some time to give feedback on this PR for me to respond to, probably PR against this branch is better. |
Documentation for representation classes
|
The tests have passed, so this could be merged now. @taldcroft, if you've started working on a branch from this, it might be better to wait until you have finished that before merging (as a PR against my branch), otherwise this can go in now and you can PR against master instead. |
|
@eteq - with apologies, I've finally cleared off some other things I had to get done and am ready for coordinates docs starting now. Looking at what's there I think my changes will be relatively contained and so it would make sense to just get this PR into master. It's easier to work off master anyway. |
|
Alright, sounds good @taldcroft - I will merge it now. |
This PR updates the coordinates documentation structure for the major APE5 changes. There are a few places that are not fully updated, all marked with
..todo ::. Theframes.rstI will take care of (either in a later update to this PR or in a separate PR if we want to merge this now). A few others are @taldcroft's purview as they deal withSkyCoord, and the representations docs are probably better done by @astrofrog, @Cadair, or both.