Skip to content

Conversation

@eteq
Copy link
Member

@eteq eteq commented May 17, 2014

This PR updates the coordinates documentation structure for the major APE5 changes. There are a few places that are not fully updated, all marked with ..todo ::. The frames.rst I will take care of (either in a later update to this PR or in a separate PR if we want to merge this now). A few others are @taldcroft's purview as they deal with SkyCoord, and the representations docs are probably better done by @astrofrog, @Cadair, or both.

@eteq
Copy link
Member Author

eteq commented May 18, 2014

Oh, and in case it's not apparent, I specifically mentioned places that require more work with .. todo:: and @whoever, so a simple find/grep in docs/*.rst will identify the places that aren't done.

@astrofrog astrofrog mentioned this pull request May 18, 2014
@astrofrog
Copy link
Member

@eteq - shall we do PRs against your branch?

@taldcroft
Copy link
Member

I'm AFK today so won't have any inputs until later.

@eteq
Copy link
Member Author

eteq commented May 18, 2014

@astrofrog - either way is fine with me - the tests are passing as-is, so this can be merged now if you or @taldcroft don't want to read over this now and would rather do separate PRs. Or if you'd rather take some time to give feedback on this PR for me to respond to, probably PR against this branch is better.

@astrofrog astrofrog added this to the v0.4.0 milestone May 18, 2014
@eteq eteq mentioned this pull request May 19, 2014
@eteq
Copy link
Member Author

eteq commented May 20, 2014

The tests have passed, so this could be merged now. @taldcroft, if you've started working on a branch from this, it might be better to wait until you have finished that before merging (as a PR against my branch), otherwise this can go in now and you can PR against master instead.

@taldcroft
Copy link
Member

@eteq - with apologies, I've finally cleared off some other things I had to get done and am ready for coordinates docs starting now. Looking at what's there I think my changes will be relatively contained and so it would make sense to just get this PR into master. It's easier to work off master anyway.

@eteq
Copy link
Member Author

eteq commented May 20, 2014

Alright, sounds good @taldcroft - I will merge it now.

eteq added a commit that referenced this pull request May 20, 2014
@eteq eteq merged commit 9a64148 into astropy:master May 20, 2014
@eteq eteq deleted the coordinates-docs-update-ape5 branch May 20, 2014 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants