@aconley and @eteq might want to take a look.

This looks good to me! @eteq or @aconley?

Sorry, I was in 'recovery from proposal writing mode' and not looking at email.

This looks good to me.

Reading the docs, it occurs to me that maybe we should provide a method for a user to make a copy of a cosmology object but with specified inputs. Right now they have to remember all the arguments. I can imagine a use case like: now I want the WMAP9 cosmology but with Om increased by 0.05.

But not a job for this pull.

@nhmc @aconley - just to check, is this ready for merging?

Yep, I think it's ready.

Ok, thanks @nhmc!

Oops, I should have left a comment indicating I was planning on reviewing this, @astrofrog and @nhmc ... I have a few quite minor comments - none are crucial, but I could either leave them here if you want to implement them in a separate PR @nhmc. Or I can try to make a PR myself (although I might not have time to do that for a while...).

If you leave the comments here, I can open a new PR.
On 21/05/2014 4:26 AM, "Erik Tollerud" [email protected] wrote:

Oops, I should have left a comment indicating I was planning on reviewing
this, @astrofrog https://github.com/astrofrog and @nhmchttps://github.com/nhmc... I have a few quite minor comments - none are crucial, but I could
either leave them here if you want to implement them in a separate PR
@nhmc https://github.com/nhmc. Or I can try to make a PR myself
(although I might not have time to do that for a while...).

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/2507#issuecomment-43664543
.