-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Fixing doctest failing in construct_table.rst #2431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing doctest failing in construct_table.rst #2431
Conversation
|
Well, I didn't think about it :( Still have to learn to think in the bigger picture. Sorry for the noise, now I doubt it's the right approach. |
|
@bsipocz - it's a corner case, so not obvious - and in fact, it may not actually be an issue. I just seem to remember things like this causing issues in very specific instances in the past. |
|
We could just use an ellipsis instead, i.e.: |
|
Sorry I should have mentioned sooner (I was doing this on Friday though and ran out the door before I had a chance) but I actually already fixed this in a branch where I was fixing Windows test failures. There's a simple workaround for this particular case to just use |
|
Meanwhile, I'm working on a separate PR (won't be ready for 0.4 though) that adds support for environment markers to the |
|
Either way really. If this is updated and merged first then it doesn't matter. |
|
Though if so I would just rebase this so that there's a just a single commit using the workaround I suggested, if at all. |
|
Done. |
|
Thanks @bsipocz! |
Fixing doctest failing in construct_table.rst
|
This affects v0.3.x too so I changed the milestone. |
Fixing doctest failing in construct_table.rst Conflicts: docs/table/construct_table.rst
This addresses the doctest failing in astropy.table mentioned in #2429