Skip to content

Conversation

@bsipocz
Copy link
Member

@bsipocz bsipocz commented May 4, 2014

This PR fixes test in test_automodapi which were failing after the recent changes in automodapi (#2370).

@astrofrog
Copy link
Member

Tested locally and fixes the tests - thanks @bsipocz!

@astrofrog astrofrog closed this May 4, 2014
@astrofrog astrofrog reopened this May 4, 2014
astrofrog added a commit that referenced this pull request May 4, 2014
@astrofrog astrofrog merged commit ec3c8c5 into astropy:master May 4, 2014
@bsipocz
Copy link
Member Author

bsipocz commented May 4, 2014

@astrofrog - Opps, in the same time of the merge, I pushed another commit with fixing the doctest failure in astropy.table mentioned in the same issue. Should I open another PR or can you merge it again?

@bsipocz
Copy link
Member Author

bsipocz commented May 4, 2014

Well, it appears that I could only push the commit to my branch, but not to this PR. So the other small fix is in #2431

@embray
Copy link
Member

embray commented May 5, 2014

Thanks for fixing this--it was really annoying me 😄

@bsipocz
Copy link
Member Author

bsipocz commented May 5, 2014

My pleasure 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants