Links broken in inheritance diagram due to change in class paths #2288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The diagrams is one of my main entry points to using the documentation. Please, let's try not to give up and turn them off. I'll try to look at this in the coming week and see if there's a low-hanging solution. |
28 tasks
Resolve links to "canonical" location of classes to "api" location of classes so that Bases and inheritance diagrams work.
ktchrn
pushed a commit
to ktchrn/astropy
that referenced
this pull request
Oct 28, 2014
Resolve links to "canonical" location of classes to "api" location of classes so that Bases and inheritance diagrams work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of #1826, links in the inheritance diagrams no longer work. For example, try clicking on a class in the diagram at:
http://docs.astropy.org/en/stable/time/index.html
then try in:
http://docs.astropy.org/en/latest/time/index.html
cc @karbary @eteq
This is causing a lot of warnings when using the Sphinx
nitpicky=Trueoption, hence how I noticed it.(Personally, I never use the diagrams, and would actually be in favor of turning them off)