Repository navigation
log exception-capturing fixes - #225
Merged
Merged
Conversation
Contributor
|
Looks good to me. I accidentally pushed the wrong button and merged this (not enough caffeine yet, obviously). I'll sort it out if for some reason this turns out to not be quite right. |
Member
Author
|
It was pretty simple, so I don't think there was much to go wrong (famous last words, though...) - many question: is @astrofrog fine with this change? |
Member
|
Yep, looks fine to me! |
keflavich
pushed a commit
to keflavich/astropy
that referenced
this pull request
Oct 9, 2013
log exception-capturing fixes
astrofrog
pushed a commit
to astrofrog/astropy
that referenced
this pull request
Jun 12, 2019
Limiting versions of setuptools and sphinx due to warnings that need 'fixin
jeffjennings
pushed a commit
to jeffjennings/astropy
that referenced
this pull request
Jul 2, 2025
Fix astropy#194: Simplify role-changing machinery with json and js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes two minor changes to how the astropy logger fomats exceptions:
str(exc)to get the message itself, instead ofexc.args[0]. The latter was failing for cases likeraise ValueErrorbecause it has noargs.