Recommit pull request due to build failure. #2233
Conversation
After random failures during build, and my failing to rebase properly, I have re-committed the code that was used in this previous pull request: astropy#2103
|
If a person could restart the build process, I think the build process will pass because only one test failed to run (all tests that ran, passed) because of some git glitch. |
|
@jbwhit - I think it would be best to change the commit message to actually describe what is fixed/implemented and not mention the rebasing problems and the other pull request. You should be able to do this with git amend: http://nathanhoad.net/git-amend-your-last-commit |
|
In general creating a new PR is also unnecessary in general--even if you rebase you can push your new commits to the existing branch over the old commits using |
3 participants
After random failures during build, and my failing to rebase properly,
I have re-committed the code that was used in this previous pull
request: #2103