Repository navigation
Convert VO documentation into the new organization - #219
Conversation
|
Just noticed that my point 4) above is a duplicate of #217. |
|
Yes, I noticed the lack of docstrings on methods too when compiling the docs for the logger. @eteq - do you have any thoughts on the other points? |
|
@mdboom - I'll address 1-3, as there is indeed already an issue for 4. Hopefully once we get this ironed out, the docs can do anything we want! (I think
|
|
@eteq: Thanks for looking at this.
|
|
(2) - hmm, odd... I'll take a look and try to fix this - I've created #231 to address this. |
|
Great, thanks! |
|
I have merged #217 here and all seems to be well. I have to move |
|
Ok, great! |
|
FYI, assuming #218 is accepted with the changes to automodapi, you'll want to add above the automodapi directive |
|
@mdboom - I think everything here has been addressed aside from your item 3, which I've added #265 to address in the future. A couple other things about this:
|
|
I'm fine to move |
|
I think this is ready to merge now. |
|
@mdboom - see eteq/astropy@bbd8dd8 - does the changes in the "using" section make things more clear? If so, I'll put it directly in master. The docs look great, now, though - merging! |
Convert VO documentation into the new organization
|
Yes -- the clarification in the template helps. Thanks! |
Convert VO documentation into the new organization
This is a first pass at converting the
io.vo's docs to use the new subpackage template as proposed in #218.There are a few issues I ran into, and maybe @eteq or others know the answers. Let me know if it makes sense to create new issues for them.
io.vodocs contain many links to the IOVA VOTable spec so that the reader can get more detail from the horse's mouth if desired. Previously, this was handled by putting a number of references indocs/vo/references.txtand including that from the top of every API doc. Now that most of the docstrings are on their own auto-generated pages, those links are no longer defined. It seems to me like we need a way to, from the automodapi directive, define some preamble to go at the top of every generated file. Or maybe there's another solution, but I'd like to avoid sprinkling these URLs all through the docstrings.At the moment, I've just used lines much longer than 80 characters, but I'm wondering if the summarizer can't be convinced to use the first paragraph rather than the first line.
get_converterthat returns one of manyConvertersubclasses. I don't want to expose these subclasses through__all__, since they shouldn't be instantiated directly, but I do want to document their methods. Any pointers?astropy.config.ConfigurationItem, the summary for itssavemethod is included in the table, but there is no link to the complete documentation forsave.