Skip to content

TST: pass suspicious-looking skip reason as a keyword argument - #20813

Draft
neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:tst/skip-reason-kwarg
Draft

neutrinoceros wants to merge 1 commit into
astropy:mainfrom
neutrinoceros:tst/skip-reason-kwarg

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Combined with pytest-dev/pytest#15367, this avoids false positives seen against pytest dev.
Will keep this one as a draft until the upstream patch is discussed

AI Disclosure

N/A

  • I certify that I am human and that I take full responsibility for this pull request including all interactions with reviewers.

Merge method

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros neutrinoceros added backport-v7.2.x on-merge: backport to v7.2.x backport-v8.0.x on-merge: backport to v8.0.x Extra CI Run cron CI as part of PR labels Nov 10, 2026
astrofrog
astrofrog previously approved these changes Nov 10, 2026
@github-project-automation github-project-automation Bot moved this from Triage to Reviewer approved in Cosmology, the Expansion Nov 10, 2026
@astrofrog
astrofrog dismissed their stale review November 10, 2026 12:19

Just realised it's a draft

pllim
pllim previously approved these changes Nov 11, 2026
@pllim
pllim dismissed their stale review November 11, 2026 14:53

Oh nvm. I see that adding reason does not get rid of the error until upstream is patched.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v7.2.x on-merge: backport to v7.2.x backport-v8.0.x on-merge: backport to v8.0.x cosmology Extra CI Run cron CI as part of PR no-changelog-entry-needed Refactoring testing Upstream Action Required Was: Upstream Fix Required

Projects

Status: Reviewer approved

Development

Successfully merging this pull request may close these issues.

4 participants