Skip to content

DEP/TST: upgrade minimal requirement on pytest to 9.0.0 - #20810

Merged
neutrinoceros merged 1 commit into
astropy:mainfrom
neutrinoceros:dep/pytest-9
Nov 9, 2026
Merged

neutrinoceros merged 1 commit into
astropy:mainfrom
neutrinoceros:dep/pytest-9

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

this came up in gh-20412
Close gh-18854 (happy BD)

AI Disclosure

N/A

  • I certify that I am human and that I take full responsibility for this pull request including all interactions with reviewers.

Merge method

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v7.2.4 milestone Nov 9, 2026
@neutrinoceros neutrinoceros added no-changelog-entry-needed dependencies Pull requests that update a dependency file backport-v7.2.x on-merge: backport to v7.2.x backport-v8.0.x on-merge: backport to v8.0.x labels Nov 9, 2026
@github-actions

github-actions Bot commented Nov 9, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim

pllim commented Nov 9, 2026

Copy link
Copy Markdown
Member

Do we really need to backport?

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

not yet, but we'll want to the second a new test is bundled with a bugfix that needs pytest 9, and trust me, I've been waiting a whole year to use its features; such tests are coming

@pllim

pllim commented Nov 9, 2026

Copy link
Copy Markdown
Member

We don't usually bump minversion in backport unless we have no other choice...

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

we could not backport yet if you're not comfortable with it. I just don't understand the argument not to, at least not for a test-only dependency.

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

(and bear in mind that it might become necessary very soon anyway)

@pllim

pllim commented Nov 9, 2026

Copy link
Copy Markdown
Member

I think it makes more sense to bump this together with the backported code that actually needs it.

@neutrinoceros neutrinoceros modified the milestones: v7.2.4, v8.1.0 Nov 9, 2026
@neutrinoceros neutrinoceros removed backport-v7.2.x on-merge: backport to v7.2.x backport-v8.0.x on-merge: backport to v8.0.x labels Nov 9, 2026
@neutrinoceros

neutrinoceros commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor Author

alright.
Is there any way to restart CircleCI other than the close/open dance ? I can't even seem to read the logs but I'm willing to bet it was the same transient network error I got with GHA at the same time.

@neutrinoceros
neutrinoceros marked this pull request as ready for review November 9, 2026 16:30
@pllim

pllim commented Nov 9, 2026

Copy link
Copy Markdown
Member

You can restart it from CircleCI dashboard. I think it can read GH permission for the repo but I don't remember which access level give you the rerun button. I restarted them for you.

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now. I'll let you decide if you also want Tom R to review. Thanks!

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

I don't think that's necessary, and I'd rather unblock his PR myself so he doesn't hold a grudge against me :D

@neutrinoceros
neutrinoceros merged commit c48a620 into astropy:main Nov 9, 2026
84 of 95 checks passed
@neutrinoceros
neutrinoceros deleted the dep/pytest-9 branch November 9, 2026 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file no-changelog-entry-needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST/DEP: upgrade to pytest 9.0

2 participants