Repository navigation
DEP/TST: upgrade minimal requirement on pytest to 9.0.0 - #20810
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
Do we really need to backport? |
|
not yet, but we'll want to the second a new test is bundled with a bugfix that needs pytest 9, and trust me, I've been waiting a whole year to use its features; such tests are coming |
|
We don't usually bump minversion in backport unless we have no other choice... |
|
we could not backport yet if you're not comfortable with it. I just don't understand the argument not to, at least not for a test-only dependency. |
|
(and bear in mind that it might become necessary very soon anyway) |
|
I think it makes more sense to bump this together with the backported code that actually needs it. |
|
alright. |
|
You can restart it from CircleCI dashboard. I think it can read GH permission for the repo but I don't remember which access level give you the rerun button. I restarted them for you. |
pllim
left a comment
There was a problem hiding this comment.
LGTM now. I'll let you decide if you also want Tom R to review. Thanks!
|
I don't think that's necessary, and I'd rather unblock his PR myself so he doesn't hold a grudge against me :D |
Description
this came up in gh-20412
Close gh-18854 (happy BD)
AI Disclosure
N/A
Merge method