Repository navigation
Fix / improve error message for comparisons - #2081
Merged
Merged
Conversation
Member
|
I concur; looks good. |
embray
added a commit
that referenced
this pull request
Feb 12, 2014
Fix / improve error message for comparisons
embray
added a commit
that referenced
this pull request
Feb 25, 2014
Fix / improve error message for comparisons
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As first noticed in #1832, the error message for a failed Time comparison is broken. The current
OperandTypeErrorclass doesn't actually provide any error text. This PR fixes that and makes the messages more informative.I don't think this rises to the level of needing mention in
CHANGES.rst.