Repository navigation
Update WCSAxes.grid() API to match Matplotlib's signature - #20784
Merged
Merged
Conversation
…lib parent class and stop CoordinateHelper.grid from silently overriding a visible keyword
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
pllim
reviewed
Nov 5, 2026
pllim
approved these changes
Nov 5, 2026
pllim
left a comment
Member
There was a problem hiding this comment.
Looks reasonable but I'll give others a chance to review. Thanks!
Member
|
I pre-emptively opened #20788 as follow-up. If the situation change here, please also update that issue accordingly. Thanks! |
larrybradley
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This fixes #15987 by deprecating the
b=keyword argument and renaming it tovisible=Since this introduces a deprecation, I don't think we should backport
AI Disclosure
If AI tools were used to develop this pull request, describe the tools including specific model and version, how they were used, and what content is AI generated. Otherwise enter "N/A".
Assisted by Opus 5.5
Merge method