Repository navigation
Fix stale values in tied parameters during fitting (closes #20710) - #20726
Onkar-Raskar wants to merge 2 commits into
Conversation
|
Hi 👋 and thank you for your contribution! 🙏 This pull request is being closed automatically - but don't worry, we may re-open it if you carefully follow these instructions. Join the astropy slack using this invite link, head over to the #new-contributor-requests channel, and introduce yourself with a post that includes:
We strongly encourage contributions from people that use astropy or actively develop related scientific Python packages. We look forward to hearing from you and growing the Astropy community! Notes for maintainersIf you know this is a genuine user and the PR is is compliance with the AI policy, you may re-open this straight away. After two successful merged pull requests, the user will be added to the allowlist and future PRs will no longer be closed automatically. This user has made other pull requests to this repository prior to this one, here is a full list: In addition, here are some statistics on the user's activity on GitHub:
|
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
@tepickering , can you pls reopen this PR and review it ? |
|
i personally don't have the power to do that. also, although this change is small, i think it merits a changelog entry since it is a bugfix: https://docs.astropy.org/en/latest/development/development_details.html#add-a-changelog-entry |
tepickering
left a comment
There was a problem hiding this comment.
i addition to the missing changelog entry, this PR needs a regression test.
|
@tepickering, i have added a log entry and regression test can you review it ? |
Fixes #20710
I have change
model._array_to_parameters()tomodel.parameters = parametersinside astropy/modeling/fitting.py also ran test suite and verified it worked without breaking.