Skip to content

Fix stale values in tied parameters during fitting (closes #20710) - #20726

Open
Onkar-Raskar wants to merge 2 commits into
astropy:mainfrom
Onkar-Raskar:Fix_modelling
Open

Onkar-Raskar wants to merge 2 commits into
astropy:mainfrom
Onkar-Raskar:Fix_modelling

Conversation

@Onkar-Raskar

Copy link
Copy Markdown
Contributor

Fixes #20710

I have change model._array_to_parameters() to model.parameters = parameters inside astropy/modeling/fitting.py also ran test suite and verified it worked without breaking.

Screenshot 2026-10-27 181602

@Onkar-Raskar
Onkar-Raskar requested a review from a team as a code owner October 27, 2026 12:48
@giles

giles Bot commented Oct 27, 2026

Copy link
Copy Markdown

Hi 👋 and thank you for your contribution! 🙏

This pull request is being closed automatically - but don't worry, we may re-open it if you carefully follow these instructions.

Join the astropy slack using this invite link, head over to the #new-contributor-requests channel, and introduce yourself with a post that includes:

  1. Background about your current occupation or affiliation.

  2. How the bug or missing feature affects your work.

We strongly encourage contributions from people that use astropy or actively develop related scientific Python packages. We look forward to hearing from you and growing the Astropy community!

Notes for maintainers

If you know this is a genuine user and the PR is is compliance with the AI policy, you may re-open this straight away. After two successful merged pull requests, the user will be added to the allowlist and future PRs will no longer be closed automatically.

This user has made other pull requests to this repository prior to this one, here is a full list:

In addition, here are some statistics on the user's activity on GitHub:

Last 24 hours Last 7 days
Pull requests opened 1 4
Issues opened 0 1

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@giles giles Bot closed this Oct 27, 2026
@Onkar-Raskar

Copy link
Copy Markdown
Contributor Author

@tepickering , can you pls reopen this PR and review it ?

@tepickering

Copy link
Copy Markdown
Contributor

i personally don't have the power to do that. also, although this change is small, i think it merits a changelog entry since it is a bugfix: https://docs.astropy.org/en/latest/development/development_details.html#add-a-changelog-entry

@pllim pllim reopened this Oct 27, 2026
@pllim pllim added this to the v8.1.0 milestone Oct 27, 2026
@pllim pllim added the Bug label Oct 27, 2026
@pllim
pllim requested a review from tepickering October 27, 2026 18:48
Comment thread astropy/modeling/fitting.py Resolved

@tepickering tepickering left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i addition to the missing changelog entry, this PR needs a regression test.

@Onkar-Raskar

Copy link
Copy Markdown
Contributor Author

@tepickering, i have added a log entry and regression test can you review it ?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

modeling: tied expressions that depend on other tied parameters see stale values during fitting

3 participants