Repository navigation
Fix surface tension physical type mapping #20681 - #20682
sanikasharma07 wants to merge 1 commit into
Conversation
|
Hi 👋 and thank you for your contribution! 🙏 This pull request is being closed automatically - but don't worry, this is not the end, and we may re-open it. For some background, we have recently started seeing a rapid increase in the number of pull requests opened. Some of these are from good-faith humans, but some of which are from autonomous LLM agents or humans using LLMs who do not have a genuine understanding of, or interest in, the project. We are therefore auto-closing pull requests from new contributors, but if you are a good-faith human, we want to make sure your pull request gets considered! So if you would like us to re-open your pull request so that it gets reviewed, you need to do two things:
The second step is important, as we may otherwise miss notifications about this pull request. To be clear, our AI policy does allow the use of LLMs as part of contributions, but we need to see authentic engagement and understanding from humans making the contribution. Notes for maintainersIf you know this is a genuine user and the PR is is compliance with the AI policy, you may re-open this straight away. After two successful merged pull requests, the user will be added to the allowlist and future PRs will no longer be closed automatically. This user has not made any pull requests to this repository prior to this one. In addition, here are some statistics on the user's activity on GitHub:
|
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
|
hello |
|
First of all, we need to check if this is a regression or a misunderstanding. Keeping PR closed for now. |
|
Understood, thank you for clarifying! |
Description
This pull request fixes the physical type mapping for surface tension by associating it with units dimensionally equivalent to
N / m, includingJy. It removes the incorrect mapping forW m² Hz⁻¹and adds tests for the affected units.Fixes #20681
Summary
Jyto bothspectral flux densityandsurface tension.W m² Hz⁻¹.Testing
git diff --checkpassed.AI Disclosure
ChatGPT (OpenAI, GPT-6) was used to help understand the issue, discuss the proposed code changes and tests, troubleshoot the local testing environment, and navigate the Git and GitHub contribution workflow. I reviewed the changes and take responsibility for the submitted contribution.
Merge method