Repository navigation
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
| repo-token: ${{ secrets.GITHUB_TOKEN }} | ||
| operations-per-run: 200 | ||
| ascending: true # Old stuff first | ||
| remove-stale-when-updated: false |
There was a problem hiding this comment.
I think this is the only part I am not sure about. According to https://github.com/actions/stale documentation, update means comments too, but we don't want that. We only want the timer to reset on new commit. Is there a way to ask actions/stale to only count last commit timestamp of a PR?
Our current policy: https://docs.astropy.org/en/latest/development/maintainers/maintainer_workflow.html#stale-policies
There was a problem hiding this comment.
I've had a think about this and I'm not sure there's a way around it. I think we should just accept that comments count and move on.
I did wonder if you could have a pull_request_target workflow which did nothing but remove the Stale label. But it wasn't clear to me from reading the actions/stale docs if that would actually work.
There was a problem hiding this comment.
I think we should just accept that comments count and move on
But then people (or non-people) can just type junk into a comment every so often to keep it alive, and that defeats the whole purpose of stale bot.
There was a problem hiding this comment.
I don't like the idea of counting comments and IMO it's a blocker in my view. If you look at the usual stale PRs there is useless chatter on it even when it's clearly not going anywhere and should be closed.
There was a problem hiding this comment.
So, does that mean we should abandon this idea and close the PR without merge?
There was a problem hiding this comment.
It seems kinda mad to me to maintain our own custom rolled thing for what seems minor
There was a problem hiding this comment.
I mean we can try, I just don't think it will be effective enough.
There was a problem hiding this comment.
Our custom thing seems to be working and just the way we like it. Why swap it out for something less?
There was a problem hiding this comment.
I updated the PR following #20601 and also updated the developer docs with what I think this new bot would do based on the settings here. Still not 100% sold.
[ci skip] [skip rtd]
|
I will resolve conflict from #20629 when we have a consensus to move forward. |
Description
This pull request is to replace a custom bot I wrote long time ago with a more standard
actions/stalethat is also used by sunpy.Fixes #20478
AI Disclosure
If AI tools were used to develop this pull request, describe the tools including specific model and version, how they were used, and what content is AI generated. Otherwise enter "N/A".
N/A
Merge method