Skip to content

RFC: refine type annotations around an invalid typevar - #20344

Merged
larrybradley merged 1 commit into
astropy:mainfrom
neutrinoceros:stats/up047
Sep 8, 2026
Merged

larrybradley merged 1 commit into
astropy:mainfrom
neutrinoceros:stats/up047

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Ref #20225

AI Disclosure

None

  • I certify that I am human and that I take full responsibility for this pull request including all interactions with reviewers.

Merge method

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v8.1.0 milestone Sep 8, 2026
@github-actions github-actions Bot added the stats label Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@larrybradley larrybradley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This function appears to always return float64 (input dtype is not preserved). Given that, we should probably use data: NDArray and -> NDArray[np.float64] .

@neutrinoceros

Copy link
Copy Markdown
Contributor Author

good call. It's actually better than that: we also know the expected dimensionality of the input and output arrays, so I've encoded them into the new annotations as well.

@neutrinoceros neutrinoceros changed the title RFC: rewrite a type annotation with a PEP 695 type parameter (stats) RFC: refine type annotations around an invalid typevar Sep 8, 2026

@larrybradley larrybradley left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@larrybradley
larrybradley merged commit d7f852d into astropy:main Sep 8, 2026
39 checks passed
@neutrinoceros
neutrinoceros deleted the stats/up047 branch September 9, 2026 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants