Repository navigation
RFC: refine type annotations around an invalid typevar - #20344
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
neutrinoceros
marked this pull request as ready for review
September 8, 2026 18:51
larrybradley
force-pushed
the
stats/up047
branch
from
September 8, 2026 20:23
13168e7 to
2fed9a2
Compare
larrybradley
reviewed
Sep 8, 2026
larrybradley
left a comment
Member
There was a problem hiding this comment.
This function appears to always return float64 (input dtype is not preserved). Given that, we should probably use data: NDArray and -> NDArray[np.float64] .
neutrinoceros
force-pushed
the
stats/up047
branch
from
September 8, 2026 20:47
2fed9a2 to
7af1587
Compare
Contributor
Author
|
good call. It's actually better than that: we also know the expected dimensionality of the input and output arrays, so I've encoded them into the new annotations as well. |
neutrinoceros
force-pushed
the
stats/up047
branch
from
September 8, 2026 20:49
7af1587 to
3177798
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ref #20225
AI Disclosure
None
Merge method