Skip to content

Backport of PR 20265 onto v7.2.x (Merged Fix MaskedColumn TypeError from stale fill_value after dtype-changing ufuncs) - #20338

Merged
pllim merged 2 commits into
astropy:v7.2.xfrom
pllim:backport-of-pr-20265-on-v7.2.x
Sep 9, 2026
Merged

Backport of PR 20265 onto v7.2.x (Merged Fix MaskedColumn TypeError from stale fill_value after dtype-changing ufuncs)#20338
pllim merged 2 commits into
astropy:v7.2.xfrom
pllim:backport-of-pr-20265-on-v7.2.x

Conversation

@pllim

@pllim pllim commented Sep 8, 2026

Copy link
Copy Markdown
Member

Description

This pull request is to manually backport #20265 onto v7.2.x because auto backport failed.

AI Disclosure

If AI tools were used to develop this pull request, describe the tools, how they were used, and what content is AI generated. Otherwise enter "N/A".

N/A

  • I certify that I am human and that I take full responsibility for this pull request including all interactions with reviewers.

Merge method

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added this to the v7.2.3 milestone Sep 8, 2026
@pllim
pllim requested a review from jdavies-st September 8, 2026 15:37
@pllim pllim added Manual Backport skip-changelog-checks Tells bot to skip changlog checks skip-basebranch-check Skip base branch check for direct backports labels Sep 8, 2026
@github-actions github-actions Bot added the table label Sep 8, 2026
@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim mentioned this pull request Sep 8, 2026
Merged
1 task
pllim
pllim commented Sep 8, 2026
View reviewed changes
Comment thread astropy/table/tests/test_column.py Resolved
jdavies-st
jdavies-st approved these changes Sep 9, 2026
View reviewed changes

@jdavies-st jdavies-st left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Given that astropy 7.2.x allows numpy 1.24 up through numpy 2.x, it has to handle both cases, which it does. But we just need the test to handle both versions of numpy.

Comment thread astropy/table/tests/test_column.py Resolved
jdavies-st and others added 2 commits September 9, 2026 14:16
@jdavies-st @pllim
Merge pull request astropy#20265 from jdavies-st/bugfix-issue20257-ma…
89268ae 
…skedcolumn-fillvalue

Fix MaskedColumn TypeError from stale fill_value after dtype-changing ufuncs

(cherry picked from commit dd8cd5e)
@pllim @jdavies-st
Fix test for numpy 1.x
3484cef 
Co-authored-by: James Davies <[email protected]>
@pllim
pllim force-pushed the backport-of-pr-20265-on-v7.2.x branch from c270efe to 3484cef Compare September 9, 2026 18:16
@pllim
pllim marked this pull request as ready for review September 9, 2026 18:16
@pllim
pllim merged commit 0b94f17 into astropy:v7.2.x Sep 9, 2026
37 checks passed
@pllim
pllim deleted the backport-of-pr-20265-on-v7.2.x branch September 9, 2026 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taldcroft taldcroft Awaiting requested review from taldcroft taldcroft is a code owner
@neutrinoceros neutrinoceros Awaiting requested review from neutrinoceros neutrinoceros is a code owner
1 more reviewer
@jdavies-st jdavies-st jdavies-st approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Manual Backport skip-basebranch-check Skip base branch check for direct backports skip-changelog-checks Tells bot to skip changlog checks table

Projects

None yet

Milestone

v7.2.3

Development

Successfully merging this pull request may close these issues.

2 participants

@pllim @jdavies-st