Skip to content

STY: extract _MAS_PER_DEG constant in ICRS<->FK5 transform - #20325

Merged
pllim merged 1 commit into
astropy:mainfrom
Pierre-Sassoulas:mas-per-deg
Sep 8, 2026
Merged

STY: extract _MAS_PER_DEG constant in ICRS<->FK5 transform#20325
pllim merged 1 commit into
astropy:mainfrom
Pierre-Sassoulas:mas-per-deg

Conversation

@Pierre-Sassoulas

@Pierre-Sassoulas Pierre-Sassoulas commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Replace the bare 3600000.0 conversion factor in _icrs_to_fk5_matrix() with a module-level _MAS_PER_DEG named constant in scientific notation. The value (3,600 arcsec/deg * 1,000 mas/arcsec) is documented in a short side comment.

Same float, more self-documenting at the call sites. Per review suggestion from neutrinoceros on #19597.

@Pierre-Sassoulas
STY: extract _MAS_PER_DEG constant in ICRS<->FK5 transform
92f1dad 
Replace the bare 3600000.0 conversion factor in _icrs_to_fk5_matrix()
with a module-level _MAS_PER_DEG named constant in scientific notation.
The value (3,600 arcsec/deg * 1,000 mas/arcsec) is documented in a
short side comment.

Same float, more self-documenting at the call sites. Per review
suggestion from neutrinoceros on PR 19597.
@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@Pierre-Sassoulas Pierre-Sassoulas mentioned this pull request Sep 6, 2026
Draft
1 task
@pllim pllim added this to the v8.1.0 milestone Sep 8, 2026
pllim
pllim approved these changes Sep 8, 2026
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems sensible. Thanks!

@pllim
pllim merged commit f75145b into astropy:main Sep 8, 2026
47 of 49 checks passed
@Pierre-Sassoulas
Pierre-Sassoulas deleted the mas-per-deg branch September 8, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

coordinates no-changelog-entry-needed Refactoring

Projects

None yet

Milestone

v8.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@Pierre-Sassoulas @pllim