Skip to content

TST: could be int32 in 32-bit arch - #20318

Closed
pllim wants to merge 1 commit into
astropy:mainfrom
pllim:fix-int-q-doctest
Closed

TST: could be int32 in 32-bit arch#20318
pllim wants to merge 1 commit into
astropy:mainfrom
pllim:fix-int-q-doctest

Conversation

@pllim

@pllim pllim commented Sep 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

#20273 did not run Extra CI so this failure got into main (armv7 job in weekly cron).

  __________ [doctest] astropy.units.quantity.preserve_dtype_by_default __________
  094 ``always`` overrides the context, giving the conversion to float of astropy
  095 7.x and earlier.
  096 
  097 Examples
  098 --------
  099 >>> import numpy as np
  100 >>> import astropy.units as u
  101 >>> with u.preserve_dtype_by_default():
  102 ...     q = u.Quantity([1, 2], u.ct)
  103 >>> q.dtype
  Expected:
      dtype('int64')
  Got:
      dtype('int32')
  
 astropy/units/quantity.py:103: DocTestFailure

Close #20373

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added this to the v8.1.0 milestone Sep 4, 2026
@pllim pllim added testing Docs Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed Extra CI Run cron CI as part of PR labels Sep 4, 2026
@github-actions github-actions Bot added the units label Sep 4, 2026
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

This was referenced Sep 4, 2026
Merged
Merged
@pllim
pllim marked this pull request as ready for review September 4, 2026 17:41
@pllim
pllim requested a review from taldcroft September 4, 2026 17:41
@pllim pllim mentioned this pull request Sep 11, 2026
Merged
1 of 2 tasks
@pllim pllim closed this in #20373 Sep 11, 2026
@pllim
pllim deleted the fix-int-q-doctest branch September 11, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@taldcroft taldcroft Awaiting requested review from taldcroft

Assignees

No one assigned

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release Docs Extra CI Run cron CI as part of PR no-changelog-entry-needed testing units

Projects

None yet

Milestone

v8.1.0

Development

Successfully merging this pull request may close these issues.

1 participant

@pllim