Repository navigation
TST,BUG: test adjustment forgotten in gh-20256 - #20262
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
| with ( | ||
| iers.conf.set_temp("iers_auto_url", "FAIL FAIL"), | ||
| iers.conf.set_temp("iers_auto_url_mirror", "https://google.com"), | ||
| iers.conf.set_temp("iers_degraded_accuracy", "ignore"), |
There was a problem hiding this comment.
This setting to "ignore" was really quite illogical, since then why should the code raise at all. This is what was fixed in #20256, but we missed that it should now be removed here.
|
OK, devdeps passes here. |
This comment was marked as spam.
This comment was marked as spam.
Huh what was this. Is this @CAOShurong an AI agent? |
|
Sorry for the confusion, and thanks for flagging it — that quoted To answer your question directly: yes, I use AI-assisted tooling as part of how I work on issues and PRs. The verification reported above was still a real run — CPython 3.13 on Windows, running If the Astropy team settles on any disclosure convention for AI-assisted contributions, I'm glad to follow it. |
|
@CAOShurong - yes, we now have an AI disclosure part for PRs; work like yours where it is used as a tool is welcome. |
This pull request is a follow-up on #20256, where I had ignored a devdeps failure that was actually related to the PR, as an assumption made in a test no longer held.