Skip to content

TST,BUG: test adjustment forgotten in gh-20256 - #20262

Merged
pllim merged 1 commit into
astropy:mainfrom
mhvk:utils-iers-devdeps-failure
Aug 24, 2026
Merged

pllim merged 1 commit into
astropy:mainfrom
mhvk:utils-iers-devdeps-failure

Conversation

@mhvk

@mhvk mhvk commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

This pull request is a follow-up on #20256, where I had ignored a devdeps failure that was actually related to the PR, as an assumption made in a test no longer held.

@mhvk mhvk added this to the v8.1.0 milestone Aug 23, 2026
@mhvk mhvk added testing Bug utils Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed utils.iers labels Aug 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@mhvk

mhvk commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

@pllim - I broke -devdeps by merging #20256 without a careful check. Could you have a look at this fix?

with (
iers.conf.set_temp("iers_auto_url", "FAIL FAIL"),
iers.conf.set_temp("iers_auto_url_mirror", "https://google.com"),
iers.conf.set_temp("iers_degraded_accuracy", "ignore"),

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This setting to "ignore" was really quite illogical, since then why should the code raise at all. This is what was fixed in #20256, but we missed that it should now be removed here.

@mhvk

mhvk commented Aug 23, 2026

Copy link
Copy Markdown
Contributor Author

OK, devdeps passes here.

@CAOShurong

This comment was marked as spam.

@pllim

pllim commented Aug 24, 2026

Copy link
Copy Markdown
Member

@e:/Codex/Scratch/astropy_20262_comment.md

Huh what was this. Is this @CAOShurong an AI agent?

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim
pllim merged commit 53d6fa1 into astropy:main Aug 24, 2026
60 of 62 checks passed
@mhvk
mhvk deleted the utils-iers-devdeps-failure branch August 24, 2026 13:50
@CAOShurong

Copy link
Copy Markdown

Sorry for the confusion, and thanks for flagging it — that quoted `@e:/...` line was a leftover from my drafting workflow: I compose longer comments locally before posting, and a scratch-file reference line accidentally got into the first version of the comment above (it has since been removed by edit).

To answer your question directly: yes, I use AI-assisted tooling as part of how I work on issues and PRs. The verification reported above was still a real run — CPython 3.13 on Windows, running test_iers.py at the merge commit 9f4de8d6 (reproduced the failure: DID NOT RAISE ValueError) and at this PR's head 086e1d35 (passes) — and I stand behind its accuracy.

If the Astropy team settles on any disclosure convention for AI-assisted contributions, I'm glad to follow it.

@mhvk

mhvk commented Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

@CAOShurong - yes, we now have an AI disclosure part for PRs; work like yours where it is used as a tool is welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release Bug no-changelog-entry-needed testing utils.iers utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants