Repository navigation
TST/DEP: simplify devdeps requirements - #20179
neutrinoceros wants to merge 3 commits into
Conversation
neutrinoceros
added
testing
no-changelog-entry-needed
dependencies
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
2d670e7 to
605cfee
Compare
|
Does this have side effects for devs using tox to test locally? |
|
None intended. This is purely housecleaning. |
pllim
left a comment
pllim
left a comment
There was a problem hiding this comment.
I don't think this works correctly. I see stable numpy being installed in devdeps with and without scipy in weekly cron (https://github.com/astropy/astropy/actions/runs/30627593365/job/91146325980?pr=20179)
|
Looks like it is such on I think we need to understand this problem before we proceed. See #20196 |
|
Now that I figured out #20196, I think it's safe to say that it is completely orthogonal. Can we treat it as such and not block one on the other ? |
d9782e3 to
3057c2b
Compare
|
I want a apple to apple log comparison, so I rebased for you. Thanks for your patience! |
| # https://github.com/tox-dev/tox/issues/3433 | ||
| # But we cannot use alldeps because it messed up oldest-deps pins. | ||
| devdeps-!noscipy: objgraph>=1.6.0 | ||
| devdeps-!noscipy: skyfield>=1.20 |
There was a problem hiding this comment.
I don't see skyfield installed in https://github.com/astropy/astropy/actions/runs/30925598933/job/92046974314?pr=20179
I don't think we can remove this.
There was a problem hiding this comment.
On main, even though numpy dev refuses to install, you can see that it still installed skyfield==1.54
There was a problem hiding this comment.
it is part of the test_all extra though
There was a problem hiding this comment.
I don't have an explanation for this quirk off hand. I suspect a bug in tox.
There was a problem hiding this comment.
I think it is in the comments above.
There was a problem hiding this comment.
if so, that means the linked report was closed prematurely 😵💫
|
Since not all of this works as intended, I'll try to split this PR into smaller ones. |
3057c2b to
bc473f6
Compare
|
Actually let me try one last thing here |
|
A couple jobs just failed on network errors while fetching from PyPI. I'll power-cycle this PR in a couple hours. |
bc473f6 to
0c1c1ee
Compare
Description
pip_pre=truescipy+matplotlibis an almost complete subset of what therecommendedextra already does. It's both simpler and slightly more useful, as well as future-proof to require the extra insteadextension-helpersis a build-time dependency, not a runtime one. Installing it from source in the runtime env has no practical effect so it's misleading to require it in this env