Skip to content

Backport PR 20132 on branch v7.2.x (BUG: support numpy's unwrap ufunc) - #20170

Merged
pllim merged 1 commit into
astropy:v7.2.xfrom
pllim:backport-of-pr-20132-on-v7.2.x
Jul 30, 2026
Merged

Backport PR 20132 on branch v7.2.x (BUG: support numpy's unwrap ufunc)#20170
pllim merged 1 commit into
astropy:v7.2.xfrom
pllim:backport-of-pr-20132-on-v7.2.x

Conversation

@pllim

@pllim pllim commented Jul 30, 2026

Copy link
Copy Markdown
Member

Description

This pull request is to manually backport #20132 onto v7.2.x

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros @mhvk @pllim
BUG: support numpy's unwrap ufunc (astropy#20132)
260d932 
Co-authored-by: Marten H. van Kerkwijk <[email protected]>
(cherry picked from commit 55da6b4)
@pllim pllim added this to the v7.2.3 milestone Jul 30, 2026
@github-actions

github-actions Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim pllim mentioned this pull request Jul 30, 2026
Merged
1 task
@pllim
pllim marked this pull request as ready for review July 30, 2026 18:35
@pllim

pllim commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

covariance failures are unrelated, ufunc error is gone

@pllim
pllim requested review from mhvk and neutrinoceros July 30, 2026 18:35
mhvk
mhvk approved these changes Jul 30, 2026
View reviewed changes

@mhvk mhvk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@pllim
pllim merged commit 7eb57b4 into astropy:v7.2.x Jul 30, 2026
45 of 50 checks passed
@pllim
pllim deleted the backport-of-pr-20132-on-v7.2.x branch July 30, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhvk mhvk mhvk approved these changes
@neutrinoceros neutrinoceros Awaiting requested review from neutrinoceros

Assignees

No one assigned

Labels

Manual Backport no-changelog-entry-needed numpy-dev skip-basebranch-check Skip base branch check for direct backports units utils

Projects

None yet

Milestone

v7.2.3

Development

Successfully merging this pull request may close these issues.

3 participants

@pllim @mhvk @neutrinoceros