Skip to content

TST: Add back pytest-filter-subpackage - #20165

Merged
neutrinoceros merged 2 commits into
astropy:mainfrom
pllim:tst-filter-subpkg
Jul 30, 2026
Merged

neutrinoceros merged 2 commits into
astropy:mainfrom
pllim:tst-filter-subpkg

Conversation

@pllim

@pllim pllim commented Jul 30, 2026

Copy link
Copy Markdown
Member

Description

This pull request is to

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@pllim pllim added this to the v8.1.0 milestone Jul 30, 2026
@pllim
pllim requested review from astrofrog and mhvk July 30, 2026 15:31
@pllim pllim added testing Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed dependencies Pull requests that update a dependency file labels Jul 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros neutrinoceros left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This plugin isn't used at all in CI, and presumably not relied on by downstream consumers (at least I really hope not), so I still think it'd make more sense as part of the dev-all dependency group, though, I recognize that it may be a case of "practicality beats purity".

@pllim
pllim marked this pull request as ready for review July 30, 2026 16:17
@pllim

pllim commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

Yes, I think we should be practical here. Removing it unceremoniously in #18784 and making core maintainers unhappy is not going to help us retain maintainers. 😉

@mhvk mhvk left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, please let's just add it back! I like it and am used to it, also for my other packages.

@astrofrog

Copy link
Copy Markdown
Member

I have to admit I still don't remember how to install dependency groups, after doing pip install .[test] for 15 years it's a hard habit to break 😆

@pllim

pllim commented Jul 30, 2026

Copy link
Copy Markdown
Member Author

@neutrinoceros you okay with merging this? Thanks, all!

@neutrinoceros

Copy link
Copy Markdown
Contributor

I still don't remember how to install dependency groups

--group <name-of-the-group> it's actually more discoverable than "extras" requiring special syntax

@neutrinoceros
neutrinoceros merged commit c586ab9 into astropy:main Jul 30, 2026
37 of 38 checks passed
@pllim
pllim deleted the tst-filter-subpkg branch July 30, 2026 20:59
neutrinoceros pushed a commit to neutrinoceros/astropy that referenced this pull request Aug 4, 2026
neutrinoceros pushed a commit to neutrinoceros/astropy that referenced this pull request Aug 4, 2026
neutrinoceros pushed a commit to neutrinoceros/astropy that referenced this pull request Aug 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release dependencies Pull requests that update a dependency file no-changelog-entry-needed testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pytest -P <module> no longer works!

4 participants