Skip to content

TST/BUG: address ISC004 violations (io.fits) - #20117

Merged
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:io.fits/isc004
Jul 24, 2026
Merged

pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:io.fits/isc004

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Original motivatio: #20113
I believe this one is an actual defect in the original test and that ruff correctly identified the issue with it.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v7.2.3 milestone Jul 24, 2026
@neutrinoceros neutrinoceros added testing Bug no-changelog-entry-needed backport-v7.2.x on-merge: backport to v7.2.x backport-v8.0.x on-merge: backport to v8.0.x labels Jul 24, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros
neutrinoceros marked this pull request as ready for review July 24, 2026 12:50
@neutrinoceros
neutrinoceros requested a review from saimn as a code owner July 24, 2026 12:50

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. I agree. Thanks!

@pllim
pllim merged commit 6fd0bd6 into astropy:main Jul 24, 2026
57 of 60 checks passed
@neutrinoceros
neutrinoceros deleted the io.fits/isc004 branch July 24, 2026 15:03
pllim added a commit that referenced this pull request Jul 24, 2026
…117-on-v7.2.x

Backport PR #20117 on branch v7.2.x (TST/BUG: address `ISC004` violations (`io.fits`))
pllim added a commit that referenced this pull request Jul 24, 2026
…117-on-v8.0.x

Backport PR #20117 on branch v8.0.x (TST/BUG: address `ISC004` violations (`io.fits`))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants