Skip to content

RFC: address ISC004 violations (utils) - #20115

Merged
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:utils/isc004
Jul 24, 2026
Merged

RFC: address ISC004 violations (utils)#20115
pllim merged 1 commit into
astropy:mainfrom
neutrinoceros:utils/isc004

Conversation

@neutrinoceros

@neutrinoceros neutrinoceros commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Description

Ref #20113

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v8.1.0 milestone Jul 24, 2026
@github-actions

github-actions Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions github-actions Bot added the utils label Jul 24, 2026
@neutrinoceros neutrinoceros mentioned this pull request Jul 24, 2026
Closed
pllim
pllim reviewed Jul 24, 2026
View reviewed changes
Comment thread astropy/utils/tests/test_data.py
[
b"\xd7\x94\xd7\x90\xd7\xa1\xd7\x98\xd7\xa8\xd7\x95\xd7\xa0\xd7\x95"
b"\xd7\x9e\xd7\x99 \xd7\xa4\xd7\x99\xd7\x99\xd7\xaa\xd7\x95\xd7\x9f"
(

@pllim pllim Jul 24, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how the extra parentheses here is any improvement. Can we exclude this one from ruff rage?

@neutrinoceros neutrinoceros Jul 24, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISC004 flags implicit str/bytes concatenation in collections (list here), because they are often not desired and an actual bug (if they're meant to be separate strings). Additional bracing parentheses is understood by ruff to express intentionality, and is more likely to be portable with other linters than a # noqa comment, should we migrate to something else in the future.

pllim
pllim approved these changes Jul 24, 2026
View reviewed changes

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a fan of this one but I also don't want to waste time arguing with a linter, so let's just merge.

@pllim
pllim merged commit a867c60 into astropy:main Jul 24, 2026
50 of 53 checks passed
@neutrinoceros
neutrinoceros deleted the utils/isc004 branch July 24, 2026 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pllim pllim pllim approved these changes

Assignees

No one assigned

Labels

no-changelog-entry-needed Refactoring utils

Projects

None yet

Milestone

v8.1.0

Development

Successfully merging this pull request may close these issues.

2 participants

@neutrinoceros @pllim