Repository navigation
Conversation
Contributor
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
Signed-off-by: Simon Aguilera <[email protected]>
Signed-off-by: Simon Aguilera <[email protected]>
nomad3
force-pushed
the
fix-18704-nested-data-mask
branch
from
July 28, 2026 21:27
d048f24 to
c21ca6c
Compare
nomad3
marked this pull request as ready for review
July 28, 2026 21:28
nomad3
requested review from
dhomeier,
neutrinoceros and
taldcroft
as code owners
July 28, 2026 21:28
Signed-off-by: Simon Aguilera <[email protected]>
neutrinoceros
removed their request for review
October 28, 2026 11:24
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request makes
Table.write(..., serialize_method="data_mask")propagate the selected mask serialization into compatible masked components nested inside mixin columns.For a masked
SkyCoord, this writes separatesc.ra.maskandsc.dec.maskcolumns, preserving both independently masked components and their underlying values. Selector matching remains at the original table-column level for string, column-name, and column-class forms. Nested serializers that do not support masked-data methods, such as aTimestored inSkyCoord.obstime, retain their existing serialization.The regression uses disjoint coordinate masks and distinct underlying data, and also checks default behavior, a nonmatching selector, context restoration, and nested
Time.Fixes #18704
Validation
pytest -q astropy/table/tests astropy/io/ascii/tests/test_ecsv.py astropy/utils/masked/tests/test_table.py— 2,930 passed, 183 skipped, 14 xfailedpytest -q astropy/io/fits/tests/test_connect.py astropy/io/misc/tests/test_hdf5.py— 175 passed, 123 skippedgit range-diffconfirms that rebasing onto currentmaindid not change either patchAI assistance
I used OpenAI Codex and Anthropic Claude Code as development and review assistants, with human direction and review throughout. I have reviewed and understand the submitted implementation and tests, take responsibility for all submitted content and licensing compliance, and will engage directly with reviewer questions and feedback.