Skip to content

Remove deprecated introspection.isinstancemethod() and introspection.find_mod_objs() - #19770

Draft
jomigmonte wants to merge 3 commits into
astropy:mainfrom
jomigmonte:fix-issue-15936
Draft

jomigmonte wants to merge 3 commits into
astropy:mainfrom
jomigmonte:fix-issue-15936

Conversation

@jomigmonte

@jomigmonte jomigmonte commented May 19, 2026 •

Copy link
Copy Markdown

Description

This pull request addresses the removal of the deprecated methods introspection.isinstancemethod() and introspection.find_mod_objs(), along with their respective tests.

Fixes #15936

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@github-actions github-actions Bot added the utils label May 19, 2026
@pllim pllim added this to the v9.0.0 milestone May 19, 2026
@pllim pllim added the API change PRs and issues that change an existing API, possibly requiring a deprecation period label May 19, 2026
@pllim

pllim commented May 20, 2026

Copy link
Copy Markdown
Member

Thanks! Looks good at a glance but will have to re-review again when the time comes when we can actually merge this. Will just have to let this sit for now.

@github-actions github-actions Bot added the Close? Tell stale bot that this issue/PR is stale label Oct 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Hi humans 👋 - this pull request hasn't had any new commits for approximately 5 months. I plan to close this in a month if the pull request doesn't have any new commits by then.

In lieu of a stalled pull request, please consider closing this and open an issue instead if a reminder is needed to revisit in the future.

If this PR still needs to be reviewed, as an author, you can rebase it to reset the clock.

If you believe I commented on this pull request incorrectly, please report this here.

@pllim pllim removed the Close? Tell stale bot that this issue/PR is stale label Oct 19, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

API change PRs and issues that change an existing API, possibly requiring a deprecation period utils

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MNT: Remove deprecated introspection.isinstancemethod() and introspection.find_mod_objs()

2 participants