Repository navigation
Make class-scoped cosmology test fixtures @classmethod for pytest 9.1 - #19748
Conversation
|
Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.
|
There was a problem hiding this comment.
We usually don't include change log for test only changes but I guess in this case, it doesn't hurt.
There was a problem hiding this comment.
But should we move this to under cosmology section?
pllim
left a comment
There was a problem hiding this comment.
Thank you so much for tackling this. I am glad it turns out to be simpler than refactoring all the inheritance. devinfra is green here, so I am approving. Just a small question about change log.
|
Timeouts in devdeps are unrelated |
|
Can someone remove the changelog commit? I'm not at the computer for a few hours, I think we don't need a changelog entry here as @pllim pointed out. If no one gets a change I'll do it later. |
[ci skip]
|
I removed it the lazy way. There is no need to rerun CI. I will squash and merge. Thanks! |
…748-on-v7.2.x Backport PR #19748 on branch v7.2.x (Make class-scoped cosmology test fixtures @classmethod for pytest 9.1)
…ethod for pytest 9.1 (#19750) Co-authored-by: Thomas Robitaille <[email protected]>
This should hopefully fix the pytest dev failures in the cron job?
Fix #19742