Skip to content

TST: only mock Path.home where needed - #19712

Merged
astrofrog merged 1 commit into
astropy:mainfrom
neutrinoceros:tst/support-unset-home
May 15, 2026
Merged

astrofrog merged 1 commit into
astropy:mainfrom
neutrinoceros:tst/support-unset-home

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

Close #19648

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added this to the v8.0.0 milestone May 8, 2026
@neutrinoceros neutrinoceros added testing Bug Affects-dev PRs and issues that do not impact an existing Astropy release no-changelog-entry-needed backport-v8.0.x on-merge: backport to v8.0.x labels May 8, 2026
@github-actions github-actions Bot added the config label May 8, 2026
@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@pllim
pllim force-pushed the tst/support-unset-home branch from 0b2c68f to 8208061 Compare May 14, 2026 22:16
@pllim

pllim commented May 14, 2026

Copy link
Copy Markdown
Member

Should I get this in first before we review #19650 in earnest?

@pllim pllim added the Extra CI Run cron CI as part of PR label May 14, 2026
@neutrinoceros

Copy link
Copy Markdown
Contributor Author

They are independent, but I guess this one is much smaller so yeah, it's easier to merge it first.

@astrofrog
astrofrog merged commit e1bdbcd into astropy:main May 15, 2026
50 of 53 checks passed
@neutrinoceros
neutrinoceros deleted the tst/support-unset-home branch May 15, 2026 12:39
pllim added a commit that referenced this pull request May 15, 2026
…712-on-v8.0.x

Backport PR #19712 on branch v8.0.x (TST: only mock Path.home where needed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Affects-dev PRs and issues that do not impact an existing Astropy release backport-v8.0.x on-merge: backport to v8.0.x Bug config Extra CI Run cron CI as part of PR no-changelog-entry-needed testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: 20 test failures when unsetting the HOME env var

3 participants