Skip to content

TST: centralize parameters on a test from #18703 - #19709

Merged
taldcroft merged 1 commit into
astropy:mainfrom
neutrinoceros:table/tst/clarify-parametrization
Jun 12, 2026
Merged

taldcroft merged 1 commit into
astropy:mainfrom
neutrinoceros:table/tst/clarify-parametrization

Conversation

@neutrinoceros

Copy link
Copy Markdown
Contributor

Description

A quick follow up to #18703.
I suggested this change in review but they were skipped for lack of time.

  • By checking this box, the PR author has requested that maintainers do NOT use the "Squash and Merge" button. Maintainers should respect this when possible; however, the final decision is at the discretion of the maintainer that merges the PR.

@neutrinoceros neutrinoceros added backport-v8.0.x on-merge: backport to v8.0.x Refactoring testing labels May 7, 2026
@neutrinoceros neutrinoceros added this to the v8.0.0 milestone May 7, 2026
@github-actions github-actions Bot added the table label May 7, 2026
@github-actions

github-actions Bot commented May 7, 2026

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Astropy! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the Astropy coding guidelines?
  • Are tests added/updated as required? If so, do they follow the Astropy testing guidelines?
  • Are docs added/updated as required? If so, do they follow the Astropy documentation guidelines?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions. Also see instructions for rebase and squash.
  • Did the CI pass? If no, are the failures related? If you need to run daily and weekly cron jobs as part of the PR, please apply the "Extra CI" label. Codestyle issues can be fixed by the bot.
  • Is a change log needed? If yes, did the change log check pass? If no, add the "no-changelog-entry-needed" label. If this is a manual backport, use the "skip-changelog-checks" label unless special changelog handling is necessary.
  • Is this a big PR that makes a "What's new?" entry worthwhile and if so, is (1) a "what's new" entry included in this PR and (2) the "whatsnew-needed" label applied?
  • At the time of adding the milestone, if the milestone set requires a backport to release branch(es), apply the appropriate "backport-X.Y.x" label(s) before merge.

@neutrinoceros
neutrinoceros marked this pull request as ready for review May 7, 2026 16:24
@neutrinoceros
neutrinoceros requested a review from taldcroft as a code owner May 7, 2026 16:24
@pllim

pllim commented May 18, 2026

Copy link
Copy Markdown
Member

@taldcroft are you able to review? 🙏

@taldcroft taldcroft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@taldcroft taldcroft modified the milestones: v8.0.0, v8.1.0 Jun 12, 2026
@taldcroft taldcroft removed the backport-v8.0.x on-merge: backport to v8.0.x label Jun 12, 2026
@taldcroft
taldcroft merged commit b57bfbf into astropy:main Jun 12, 2026
61 of 65 checks passed
@neutrinoceros
neutrinoceros deleted the table/tst/clarify-parametrization branch June 12, 2026 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants